Skip to content

Bump semver from 6.3.0 to 7.1.1 #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 20, 2019

Bumps semver from 6.3.0 to 7.1.1.

Changelog

Sourced from semver's changelog.

changes log

7.1.0

  • Add require('semver/preload') to load the entire module without using lazy getter methods.

7.0.0

  • Refactor module into separate files for better tree-shaking
  • Drop support for very old node versions, use const/let, => functions, and classes.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@rust-highfive
Copy link

r? @smarnach

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Dec 20, 2019

☔ The latest upstream changes (presumably #2009) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/semver-7.1.1 branch 3 times, most recently from c27bfa8 to de3c385 Compare December 20, 2019 09:59
@locks
Copy link
Contributor

locks commented Dec 20, 2019

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/semver-7.1.1 branch 2 times, most recently from aa360fb to 5e23e9f Compare December 20, 2019 13:01
@bors
Copy link
Contributor

bors commented Dec 21, 2019

☔ The latest upstream changes (presumably #2034) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/semver-7.1.1 branch 5 times, most recently from 7981960 to 481cdab Compare December 28, 2019 16:41
@carols10cents
Copy link
Member

it looks like this is a legit failure, seems that the internal structure of the package changed and the import doesn't work anymore?

            ERROR: Error while processing route: crate.index Cannot find module './functions/prerelease' Error: Cannot find module './functions/prerelease'

                at webpackEmptyContext (webpack://__ember_auto_import__/./node_modules/semver_sync?:2:10)

                at lazyRequire (webpack://__ember_auto_import__/./node_modules/semver/index.js?:4:111)

                at Object.get [as prerelease] (webpack://__ember_auto_import__/./node_modules/semver/index.js?:12:19)

                at isUnstableVersion (http://localhost:7357/assets/cargo.js:5752:58)

                at Class.model (http://localhost:7357/assets/cargo.js:5771:13)

                at Class.deserialize (http://localhost:7357/assets/vendor.js:38975:19)

                at UnresolvedRouteInfoByParam.getModel (http://localhost:7357/assets/vendor.js:76668:24)

                at http://localhost:7357/assets/vendor.js:76464:229

                at invokeCallback (http://localhost:7357/assets/vendor.js:78530:17)

                at publish (http://localhost:7357/assets/vendor.js:78513:9)

I... tried a few things and couldn't get it to work though :(

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/semver-7.1.1 branch from 481cdab to d152dec Compare January 3, 2020 18:31
@locks
Copy link
Contributor

locks commented Jan 4, 2020

@carols10cents I think I got it! Let's see what CI says.

@jtgeibel
Copy link
Member

jtgeibel commented Jan 5, 2020

LGTM!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 5, 2020

📌 Commit febd74b has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Jan 5, 2020

⌛ Testing commit febd74b with merge d11b259...

bors added a commit that referenced this pull request Jan 5, 2020
… r=jtgeibel

Bump semver from 6.3.0 to 7.1.1

Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 7.1.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/npm/node-semver/blob/master/CHANGELOG.md">semver's changelog</a>.</em></p>
<blockquote>
<h1>changes log</h1>
<h2>7.1.0</h2>
<ul>
<li>Add <code>require('semver/preload')</code> to load the entire module without using
lazy getter methods.</li>
</ul>
<h2>7.0.0</h2>
<ul>
<li>Refactor module into separate files for better tree-shaking</li>
<li>Drop support for very old node versions, use const/let, <code>=&gt;</code> functions,
and classes.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/npm/node-semver/commit/bb36c98d71d5760d730abba71c68bc324035dd36"><code>bb36c98</code></a> 7.1.1</li>
<li><a href="https://github.com/npm/node-semver/commit/6648df16df5920f78af16a8af0711a4994996043"><code>6648df1</code></a> Add preload.js into npm package</li>
<li><a href="https://github.com/npm/node-semver/commit/5a4ce3df0c9d71900313ae165b3d31abb38dc85f"><code>5a4ce3d</code></a> changelog for 7.1</li>
<li><a href="https://github.com/npm/node-semver/commit/e663d38c2d3f77bfe8c9cae9770c409aa434c713"><code>e663d38</code></a> 7.1.0</li>
<li><a href="https://github.com/npm/node-semver/commit/945d53c0979d9894343d07ffb615f7ce66cc1cbe"><code>945d53c</code></a> Add semver/preload module to just load the whole thing like it used to be</li>
<li><a href="https://github.com/npm/node-semver/commit/d61f828e64260a0a097f26210f5500e91a621828"><code>d61f828</code></a> update changelog, travis, and engines versions</li>
<li><a href="https://github.com/npm/node-semver/commit/533ed1266b44d7672ad5015202c0e571da15b8c1"><code>533ed12</code></a> update tap</li>
<li><a href="https://github.com/npm/node-semver/commit/f56505b1c08856a7e6139f6ee5d4580f5f2feed8"><code>f56505b</code></a> 7.0.0</li>
<li><a href="https://github.com/npm/node-semver/commit/7d834ed5dcd3ded832f8cd4e51f64261cb3cbb24"><code>7d834ed</code></a> document exported modules</li>
<li><a href="https://github.com/npm/node-semver/commit/bbb1d02260dbbb99c8599f43c16ef837f102c249"><code>bbb1d02</code></a> Add default npm OSS GitHub settings</li>
<li>Additional commits viewable in <a href="https://github.com/npm/node-semver/compare/v6.3.0...v7.1.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=semver&package-manager=npm_and_yarn&previous-version=6.3.0&new-version=7.1.1)](https://dependabot.com/compatibility-score.html?dependency-name=semver&package-manager=npm_and_yarn&previous-version=6.3.0&new-version=7.1.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
@bors
Copy link
Contributor

bors commented Jan 5, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing d11b259 to master...

@bors bors merged commit febd74b into master Jan 5, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/semver-7.1.1 branch January 5, 2020 18:57
@carols10cents
Copy link
Member

thank you @locks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants